From d6c79ae0e0f652fa0c02b702e476a65235e73edf Mon Sep 17 00:00:00 2001 From: Miroslav Pejic Date: Wed, 1 Jan 2025 01:43:30 +0100 Subject: [PATCH] [mirotalk] - fix --- app/src/server.js | 9 +++++++-- package.json | 2 +- public/js/client.js | 4 ++-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/app/src/server.js b/app/src/server.js index f943e6a9..9aa0aeb9 100755 --- a/app/src/server.js +++ b/app/src/server.js @@ -39,7 +39,7 @@ dependencies: { * @license For commercial use or closed source, contact us at license.mirotalk@gmail.com or purchase directly from CodeCanyon * @license CodeCanyon: https://codecanyon.net/item/mirotalk-p2p-webrtc-realtime-video-conferences/38376661 * @author Miroslav Pejic - miroslav.pejic.85@gmail.com - * @version 1.4.23 + * @version 1.4.24 * */ @@ -547,6 +547,11 @@ app.get('/join/', async (req, res) => { */ const { room, name, audio, video, screen, notify, hide, token } = checkXSS(req.query); + if (!room) { + log.warn('/join/params room empty', room); + return res.status(401).json({ message: 'Direct Room Join: Missing mandatory room parameter!' }); + } + const allowRoomAccess = isAllowedRoomAccess('/join/params', req, hostCfg, peers, room); if (!allowRoomAccess && !token) { @@ -707,7 +712,7 @@ app.get('/:roomId', (req, res) => { } log.debug('Detected roomId --> redirect to /join?room=roomId'); - res.redirect(`/join?room=${roomId}`); // `/join/${roomId}` + res.redirect(`/join/${roomId}`); }); /** diff --git a/package.json b/package.json index df4fe9e6..4437a465 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "mirotalk", - "version": "1.4.23", + "version": "1.4.24", "description": "A free WebRTC browser-based video call", "main": "server.js", "scripts": { diff --git a/public/js/client.js b/public/js/client.js index bc25cef9..f54878cd 100644 --- a/public/js/client.js +++ b/public/js/client.js @@ -15,7 +15,7 @@ * @license For commercial use or closed source, contact us at license.mirotalk@gmail.com or purchase directly from CodeCanyon * @license CodeCanyon: https://codecanyon.net/item/mirotalk-p2p-webrtc-realtime-video-conferences/38376661 * @author Miroslav Pejic - miroslav.pejic.85@gmail.com - * @version 1.4.23 + * @version 1.4.24 * */ @@ -10789,7 +10789,7 @@ function showAbout() { Swal.fire({ background: swBg, position: 'center', - title: 'WebRTC P2P v1.4.23', + title: 'WebRTC P2P v1.4.24', imageAlt: 'mirotalk-about', imageUrl: images.about, customClass: { image: 'img-about' },