From 6ff9db1be12361e247a8e33d38ef91db9acf8a29 Mon Sep 17 00:00:00 2001 From: Rahul Jain Date: Wed, 15 Oct 2025 21:13:50 +0530 Subject: [PATCH] chore: fix asset path & refactor deploy config --- .github/workflows/deploy.yml | 2 -- src/app/layout.tsx | 13 +++++++++---- src/components/layout/footer.tsx | 12 +++++++++++- src/components/layout/header.tsx | 5 ++++- 4 files changed, 24 insertions(+), 8 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index b3438d5..ff2d6d4 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -3,8 +3,6 @@ name: Build and Deploy on: push: branches: [master, dev] - pull_request: - branches: [master, dev] # Allow concurrent deployments for different environments concurrency: diff --git a/src/app/layout.tsx b/src/app/layout.tsx index fe712ed..da1895b 100644 --- a/src/app/layout.tsx +++ b/src/app/layout.tsx @@ -80,6 +80,14 @@ export const metadata: Metadata = { creator: '@rahuldkjain', images: ['/og-image.png'], }, + icons: { + icon: [ + { url: '/favicon.ico', sizes: 'any' }, + { url: '/mdg.png', type: 'image/png' }, + ], + apple: '/mdg.png', + }, + manifest: '/manifest.json', robots: { index: true, follow: true, @@ -130,10 +138,7 @@ export default function RootLayout({ return ( - - - - + {/* Favicon and manifest are now handled by Next.js metadata API above */} diff --git a/src/components/layout/footer.tsx b/src/components/layout/footer.tsx index df5292e..21e94b7 100644 --- a/src/components/layout/footer.tsx +++ b/src/components/layout/footer.tsx @@ -1,4 +1,8 @@ import Link from 'next/link'; +import Image from 'next/image'; + +// Import the logo as a static asset for GitHub Pages compatibility +import logoImage from '../../images/mdg.png'; export function Footer() { return ( @@ -6,7 +10,13 @@ export function Footer() {
{/* Logo Section */}
- GitHub Profile README Generator Logo + GitHub Profile README Generator Logo GitHub Profile README Generator
diff --git a/src/components/layout/header.tsx b/src/components/layout/header.tsx index b9945f4..9c43179 100644 --- a/src/components/layout/header.tsx +++ b/src/components/layout/header.tsx @@ -7,6 +7,9 @@ import { ThemeToggle } from '@/components/ui/theme-toggle'; import { AccessibilityMenu } from '@/components/ui/accessibility-menu'; import { GitHubStats } from '@/components/ui/github-stats'; +// Import the logo as a static asset for GitHub Pages compatibility +import logoImage from '../../images/mdg.png'; + const navigation = [ { name: 'Generator', href: '/' }, { name: 'Addons', href: '/addons' }, @@ -30,7 +33,7 @@ export function Header({}: HeaderProps = {}) {