From 1b5662f2a514072b1e22ca1ed5db38d1673cef74 Mon Sep 17 00:00:00 2001 From: therealaleph Date: Mon, 27 Apr 2026 15:50:59 +0300 Subject: [PATCH] ci(release): make i686-pc-windows-msvc continue-on-error Companion to the Rust 1.77.2 pin: if the deps' MSRV ever moves above 1.77, the i686 target will fail to build, but we don't want it to block the rest of the release. Mirror the mipsel-softfloat approach. If/when this triggers, options are dropping i686 entirely or moving to the tier-3 i686-win7-windows-msvc target. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/release.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index df7344a..1b0a79d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -112,7 +112,12 @@ jobs: # mipsel-softfloat is best-effort: the Rust tier-3 target occasionally # regresses. Letting it fail keeps the main release going so # desktop/Android users aren't blocked by MT7621 router support. - continue-on-error: ${{ matrix.mipsel_softfloat == true }} + # i686-pc-windows-msvc is similarly best-effort — pinned to Rust + # 1.77.2 for Win7 compat (#318), so a future dep MSRV bump above + # 1.77 will fail this one target. Letting it skip keeps the rest + # of the release unblocked; we'd then choose between dropping the + # target or moving to the tier-3 win7-msvc target with build-std. + continue-on-error: ${{ matrix.mipsel_softfloat == true || matrix.target == 'i686-pc-windows-msvc' }} steps: # Heal any root-owned leftovers from a previous mipsel docker